Skip to content

chore!: changed execution reverted code from 11 to 3 #6392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LesnyRumcajs wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore!: changed execution reverted code from 11 to 3 #6392

LesnyRumcajs wants to merge 2 commits into from
+3 −31

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Jan 8, 2026 •
edited by coderabbitai bot
Loading

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Breaking Changes

    • Error code used for execution-reverted responses changed from 11 to 3 — integrations depending on the previous code should be updated.

  • Documentation

    • Changelog and docs updated to reflect the new error code and its ecosystem impact.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026 •
edited
Loading

Walkthrough

Changed the execution-reverted RPC error code constant from 11 to 3 and updated the unreleased CHANGELOG entry to document this breaking change. Total lines changed: +3/-31 across 2 files.

Changes

Cohort / File(s) Summary
Error Code Update
src/rpc/methods/eth/errors.rs		 Changed pub const EXECUTION_REVERTED_CODE: i32 from 11 to 3; updated inline documentation to reflect ecosystem alignment.
Changelog
CHANGELOG.md		 Replaced previous breaking entries with a single breaking note documenting the execution reverted error code change from 11 to 3.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

RPC

Suggested reviewers

  • hanabi1224
  • sudo-shashank
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating the execution reverted error code from 11 to 3, which is the primary modification across all changed files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review January 8, 2026 13:49
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner January 8, 2026 13:49
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and sudo-shashank and removed request for a team January 8, 2026 13:49
@hanabi1224
Copy link
Contributor

hanabi1224 commented Jan 29, 2026 •
edited
Loading

Upstream PR has been merged. Should we merge this or hold until calbinet F3 reset releases are published?

@LesnyRumcajs
Copy link
Member Author

LesnyRumcajs commented Jan 29, 2026

I think we can merge it already, we'll have eventual consistency.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.71%. Comparing base (8117383) to head (491c21b).

Additional details and impacted files
Files with missing lines Coverage Δ
src/rpc/methods/eth/errors.rs 0.00% <ø> (ø)

... and 7 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8117383...491c21b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sudo-shashank
sudo-shashank requested changes Jan 29, 2026
View reviewed changes
Copy link
Contributor

@sudo-shashank sudo-shashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LesnyRumcajs changelog needs a fix accidentally you removed Forest v0.31.1 "Quadrantids" section during merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sudo-shashank sudo-shashank sudo-shashank requested changes

@hanabi1224 hanabi1224 Awaiting requested review from hanabi1224 hanabi1224 is a code owner automatically assigned from ChainSafe/forest

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LesnyRumcajs @hanabi1224 @sudo-shashank